Project Listing Page #35

sumnerevans · 2017-12-18T07:57:47Z

Resolves #13

Features

New "Projects" page listing all of the projects and viewing information about them.
Projects can be added from the admin panel
Projects can have the following properties:
- Name (required)
- Description
- Website
- Repository
- Video
- Image
- Team Members (list of users)

Questions

Currently, the image can be any shape and can be transparent. Unlike the Contact page, where the pictures have backgrounds, there is very little contrast between project images and the surrounding page. Any ideas on how to improve that?
What do you think of the overall design? I used a lot of ideas from ACM Website Redesign Proposal #15.

Screenshots

Old (for reference)

Projects page on desktop:
2017-12-18-00 36 36
2017-12-18-00 55 02

Projects page on small screen:
2017-12-18-00 49 52

New

Projects page on large screen:

Projects page on a medium-sized screen:

Projects page on a narrow screen:

jackrosenthal · 2017-12-18T18:08:00Z

acmwebsite/public/css/style.css

+    -webkit-border-radius: 4px;
+       -moz-border-radius: 4px;
+            border-radius: 4px;
+    color: #c09853;


Indentation in CSS should use 2 spaces. Please don't change this.

We've been very inconsistent with that throughout the CSS file so I was confused. I chose 4 because it seemed to be more common. (I actually prefer 2, so I'm happy to change this.)

Added note to contributing guidelines.

jackrosenthal · 2017-12-18T18:10:13Z

acmwebsite/templates/projects.xhtml

+          <b>Contributors:</b>
+          <ul>
+            <li py:for="tm in project.team_members">
+              <a href="${tg.url('/u/%s' % tm.user_name)}" py:content="tm.display_name" />


Don't use printf style formatting. The str.format function available since Python 2.5 is a better choice.

jackrosenthal · 2017-12-18T18:12:52Z

acmwebsite/lib/helpers.py

@@ -29,6 +29,10 @@ def icon(icon_name):
    return Markup('<i class="glyphicon glyphicon-%s"></i>' % icon_name)


+def fa_icon(icon_name):
+    return Markup('<i class="fa fa-%s"></i>' % icon_name)


Don't use printf style formatting. The str.format function available since Python 2.5 is a better choice.

jackrosenthal · 2017-12-18T18:14:51Z

acmwebsite/controllers/project.py

+from acmwebsite.model import DBSession, Project
+
+
+class ProjectsController(BaseController):


Will there ever be the possibility of having a page for separate projects? If yes, the OO style thing we did with the meetings/surverys might be a good choice.

Not priority... something we eventually might consider. Can be done way after this has been merged...

Yes. That's why I had this as a separate controller. It's kinda dumb right now, but in the future, I can definitely see eventually having a page for each project (for example, it may include more details about the project and/or additional media such as screenshots). I think is should be pretty easy to add on a ProjectController for the individual projects with this setup.

jackrosenthal · 2017-12-18T18:17:06Z

Currently, the image can be any shape and can be transparent. Unlike the Contact page, where the pictures have backgrounds, there is very little contrast between project images and the surrounding page. Any ideas on how to improve that?

Look at the LUG presentations page... what do you think of how that one is implemented?

sumnerevans · 2017-12-19T00:17:28Z

Look at the LUG presentations page... what do you think of how that one is implemented?

@jackrosenthal , I took some inspiration from the presentations page and updated the design here. See the new screenshots in the issue description at the top. (I left links to the old ones for reference.)

sumnerevans · 2018-01-17T04:56:50Z

@jackrosenthal , I don't think there should be anything major holding this up. Could you please re-review this PR?

samsartor · 2018-01-17T20:21:37Z

acmwebsite/controllers/root.py

@@ -49,6 +50,7 @@ class RootController(BaseController):
    schedule = ScheduleController()
    error = ErrorController()
    contact = ContactController()
+    projects = ProjectsController()


Individual projects should probably be located at acm.mines.edu/p/### (users are /u/***, surveys are /s/###, etc). Is there a way to do that while keeping the /projects list page? Adding an additional ProjectController?

This PR doesn't deal with individual project pages, so I think this is a consideration for #40. Personally, I don't like the short URLs. I think they are ugly. I've added this to the Considerations section on #40.

Let's continue use of short URLs even if Sumner does not like it... better for Emails, and looks better too.

Sorry Sumner.

@jackrosenthal, fine by me. Still doesn't matter here, this PR only deals with the project listing page. From what I can see, we agree on this URL scheme:

/projects - shows a list of all the projects with links to the individual projects

/p/<project_id> - shows the project with id project_id

I think the real question is how to implement this. I think worst case scenario we have to add a ProjectLookupController and ProjectController in addition to the ProjectsController. Alternatively, we could expose the /projects endpoint on the root controller which would avoid that mess. My only concern with that is that it clutters up the root controller.

CC: @samsartor

I was mainly thinking about future work on #40. Maybe we should eventually rename ProjectsController to ProjectListController so that it does not get confused with the incoming ProjectController and Project[s|Lookup]Controller. I'm feeling confused just listing them.

samsartor

Looks nice!

jackrosenthal · 2018-01-22T16:54:12Z

use /p/unique_textual_project_name instead of an ID. The ID makes it hard to remember or read (which destroys the whole point of the short url.

sumnerevans · 2018-01-22T17:52:33Z

@jackrosenthal , again, that's not applicable to this PR since there are no individual pages for projects as of this PR. Any feedback on individual pages should be on #40.

Out of date

sumnerevans · 2018-03-13T16:40:09Z

@samsartor , on your plate for review.

samsartor

Looks good!

sumnerevans added 6 commits December 15, 2017 23:41

#13 project database model, controller, preliminary UI

b10a2df

#13 added pretty project display

7d18779

#13 Clean up a couple of minor things

2e7a7cf

Add video URL field

0dc5ebd

#13 remove stuff regarding submitting projects

61c50bf

#13 cleaning up project page

571afbf

sumnerevans self-assigned this Dec 18, 2017

sumnerevans requested review from jackrosenthal and samsartor December 18, 2017 07:57

sumnerevans mentioned this pull request Dec 18, 2017

Show user's projects on profile page #36

Closed

jackrosenthal previously requested changes Dec 18, 2017

View reviewed changes

sumnerevans added 3 commits December 18, 2017 17:00

#13 fixed indentation, removed printf formatting

5f1aefd

#13 put project listings into panels

f7b0e68

#13 improved project listing styles

23071bf

sumnerevans mentioned this pull request Dec 21, 2017

Add config option for specifying social links #37

Merged

samsartor reviewed Jan 17, 2018

View reviewed changes

samsartor previously approved these changes Jan 17, 2018

View reviewed changes

This was referenced Jan 17, 2018

Page for each project #40

Open

RFC: Should we implement everything as a Wiki? #42

Closed

samsartor dismissed their stale review via 3551c8c January 25, 2018 18:25

samsartor force-pushed the project-page branch from 3551c8c to 23071bf Compare January 25, 2018 18:34

sumnerevans changed the base branch from master to develop January 31, 2018 02:22

Merge develop into project-page

4421d7a

samsartor approved these changes Mar 17, 2018

View reviewed changes

samsartor merged commit 5d8bab2 into develop Mar 17, 2018

sumnerevans mentioned this pull request Mar 17, 2018

Project Page and Low Hanging Fruit #64

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Project Listing Page #35

Project Listing Page #35

sumnerevans commented Dec 18, 2017 •

edited

jackrosenthal Dec 18, 2017

sumnerevans Dec 18, 2017

jackrosenthal Dec 18, 2017

jackrosenthal Dec 18, 2017

jackrosenthal Dec 18, 2017

jackrosenthal Dec 18, 2017

sumnerevans Dec 18, 2017

jackrosenthal commented Dec 18, 2017

sumnerevans commented Dec 19, 2017

sumnerevans commented Jan 17, 2018

samsartor Jan 17, 2018

sumnerevans Jan 17, 2018 •

edited

jackrosenthal Jan 18, 2018

sumnerevans Jan 18, 2018

samsartor Jan 18, 2018

samsartor left a comment

jackrosenthal commented Jan 22, 2018

sumnerevans commented Jan 22, 2018

sumnerevans commented Mar 13, 2018

samsartor left a comment

		from acmwebsite.model import DBSession, Project


		class ProjectsController(BaseController):

Project Listing Page #35

Project Listing Page #35

Conversation

sumnerevans commented Dec 18, 2017 • edited

Features

Questions

Screenshots

Old (for reference)

New

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jackrosenthal commented Dec 18, 2017

sumnerevans commented Dec 19, 2017

sumnerevans commented Jan 17, 2018

Choose a reason for hiding this comment

sumnerevans Jan 17, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samsartor left a comment

Choose a reason for hiding this comment

jackrosenthal commented Jan 22, 2018

sumnerevans commented Jan 22, 2018

sumnerevans commented Mar 13, 2018

samsartor left a comment

Choose a reason for hiding this comment

sumnerevans commented Dec 18, 2017 •

edited

sumnerevans Jan 17, 2018 •

edited