Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing invariant masses for the kinematics #4

Closed
Leongrim opened this issue Aug 18, 2020 · 3 comments · Fixed by #198
Closed

Missing invariant masses for the kinematics #4

Leongrim opened this issue Aug 18, 2020 · 3 comments · Fixed by #198
Assignees
Labels
💫 Good first issue Good for newcomers
Milestone

Comments

@Leongrim
Copy link
Contributor

At the moment it seems like the kinematics only creates the invariant masse for subsystems containing resonances because this are the only ones that are needed for the fitting.
For instance J/psi -> KS sigma+ pbar containing N(1650)+ and N(1650)- only subsystems for KS sigma+ and KS pbar are created.
Probably this has to be modified.

@spflueger
Copy link
Member

spflueger commented Aug 18, 2020

We will have to see who to assign this task to. Any volunteers?

The idea would be to generate all different subsystems using https://docs.python.org/3.7/library/itertools.html#itertools.combinations . Then simply register those Subsystems in the Kinematics instance.

@redeboer
Copy link
Member

redeboer commented Aug 18, 2020

Any volunteers?

✋ 😒
But probably best to do this together with @Leongrim because he can test it on a use case.

Some useful slides here

@spflueger
Copy link
Member

For the record, this is how it was done in ComPWA (c++) https://github.com/ComPWA/ComPWA/blob/master/Physics/HelicityFormalism/HelicityKinematics.cpp#L296

@redeboer redeboer transferred this issue from ComPWA/tensorwaves Mar 24, 2021
@redeboer redeboer transferred this issue from ComPWA/expertsystem Apr 6, 2021
@redeboer redeboer added this to the 0.8.1 milestone Apr 13, 2021
@redeboer redeboer modified the milestones: 0.8.1, 0.8.2 Apr 29, 2021
@redeboer redeboer modified the milestones: 0.9.0, 0.9.2 May 27, 2021
@redeboer redeboer modified the milestones: 0.9.2, 0.9.3, 0.9.4, 0.10.0 Jun 10, 2021
@redeboer redeboer modified the milestones: 0.10.0, 0.10.1, 0.10.2 Jun 23, 2021
@redeboer redeboer modified the milestones: 0.11.1, 0.11.2, 0.11.3 Sep 20, 2021
@redeboer redeboer modified the milestones: 0.11.5, 0.12.0 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💫 Good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants