New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UITextView.valuePublisher
#24
Conversation
Uhm this works fine under Xcode 11 but crashes in 12. @jdisho any thoughts before I dig into it? :] |
Hmm.. interesting 🤔 |
Thanks a ton @jdisho ❤️ |
Can this wait a bit more? I've been quite busy recently 😔 |
Generally, sure, but I’m waiting on this to release a version because I don’t want to cut a release that’s crashing potentially :P
Thank you very much.
Shai
…On 18 Aug 2020, 12:00 +0300, Joan Disho ***@***.***>, wrote:
Can this wait a bit more? I've been quite busy recently 😔
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Hey @jdisho, any chance you have a moment to look here? |
Yes @freak4pc, I will try to find the time this weekend. I am so sorry for this delay 🙏 |
No worries, I haven't forgotten! |
Looking forward. Thank you! :)
…On 9 Sep 2020, 18:11 +0300, Joan Disho ***@***.***>, wrote:
No worries, I haven't forgotten!
|
@jdisho sorry for pinging all the time, I know how busy you are :) Just want to make sure you remember it ^_^ |
79b8844
to
bd34bbb
Compare
@jdisho I believe I've mostly resolved this. The crash was resolved in Xcode 12 GM, but for some reason you've sent a This was masked by the tests, but in reality these publishers are "infinite" (should only send completion on deallocation of the delegate). |
This PR adds support for a
UITextView.valuePublisher
publisher based on the one in RxCocoa and NSTextStorage (based on @jdisho's delegate proxy support).Closes #19