Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UITextView.valuePublisher #24

Merged
merged 2 commits into from Sep 23, 2020
Merged

Add UITextView.valuePublisher #24

merged 2 commits into from Sep 23, 2020

Conversation

freak4pc
Copy link
Member

This PR adds support for a UITextView.valuePublisher publisher based on the one in RxCocoa and NSTextStorage (based on @jdisho's delegate proxy support).

Closes #19

@freak4pc
Copy link
Member Author

Uhm this works fine under Xcode 11 but crashes in 12.
image

@jdisho any thoughts before I dig into it? :]

@jdisho
Copy link
Contributor

jdisho commented Aug 11, 2020

Hmm.. interesting 🤔
I will have a look into this @freak4pc

@freak4pc
Copy link
Member Author

Thanks a ton @jdisho ❤️

@jdisho
Copy link
Contributor

jdisho commented Aug 18, 2020

Can this wait a bit more? I've been quite busy recently 😔

@freak4pc
Copy link
Member Author

freak4pc commented Aug 18, 2020 via email

@freak4pc
Copy link
Member Author

freak4pc commented Sep 5, 2020

Hey @jdisho, any chance you have a moment to look here?

@jdisho
Copy link
Contributor

jdisho commented Sep 5, 2020

Yes @freak4pc, I will try to find the time this weekend. I am so sorry for this delay 🙏

@jdisho
Copy link
Contributor

jdisho commented Sep 9, 2020

No worries, I haven't forgotten! ☺️

@freak4pc
Copy link
Member Author

freak4pc commented Sep 9, 2020 via email

@freak4pc
Copy link
Member Author

@jdisho sorry for pinging all the time, I know how busy you are :) Just want to make sure you remember it ^_^

@freak4pc
Copy link
Member Author

@jdisho I believe I've mostly resolved this. The crash was resolved in Xcode 12 GM, but for some reason you've sent a .finished event on the subscriber whenever a single event was published.

This was masked by the tests, but in reality these publishers are "infinite" (should only send completion on deallocation of the delegate).

@freak4pc freak4pc merged commit d1a6263 into master Sep 23, 2020
@freak4pc freak4pc deleted the uitextview branch September 23, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can I add a textPublisher to UITextView?
2 participants