Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packet/adaptationfield: private data length is not safely handled #82

Closed
kortschak opened this issue May 28, 2018 · 1 comment
Closed

packet/adaptationfield: private data length is not safely handled #82

kortschak opened this issue May 28, 2018 · 1 comment

Comments

@kortschak
Copy link
Contributor

In create.go, SetPrivateData takes a []byte for writing to private data.

Currently this does not check for length and will panic if b is too long.
@kortschak
Copy link
Contributor Author

This was updated by #84, so now it does not panic, but it does still not correctly handle cases where len(af) is not 4. I just now notice that it should also set the transport private data flag, which it currently does not. It looks to me like this will be addressed in #92.

This was referenced Aug 3, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kortschak