Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Requirements prevent installation with Symfony 7.0 dependencies present #24

Open
MArmourTCCC opened this issue Mar 27, 2024 · 5 comments
Assignees
Labels

Comments

@MArmourTCCC
Copy link
Contributor

MArmourTCCC commented Mar 27, 2024

Describe the bug
Same as this previous issue but for version 7.0.

To Reproduce
Steps to reproduce the behavior:

  1. composer require symfony/console=7.0
  2. composer require Comcast/php-legal-licenses
  3. See error:
Problem 1
    - Root composer.json requires comcast/php-legal-licenses ^1.2 -> satisfiable by comcast/php-legal-licenses[v1.2.0].
    - comcast/php-legal-licenses v1.2.0 requires symfony/console ~2.3|~3.0|~4.0|~5.0|~6.0 -> found symfony/console[v2.3.0, ..., v2.8.52, v3.0.0, ..., v3.4.47, v4.0.0, ..., v4.4.49, v5.0.0, ..., v5.4.36, v6.0.0, ..., v6.4.4] but it conflicts with your root composer.json require (7.0).

Expected behavior
The install is successful.

Run Environment (please complete the following information):
N/a

Pull Request
PR Request Added

@mcsma
Copy link

mcsma commented May 7, 2024

@orediggerco did you consider merging @MArmourTCCC s PR? symfony 7 compatability is currently limiting the use of this software. Would greatly appreciate you having a look.

@orediggerco
Copy link
Member

orediggerco commented May 7, 2024

Hey @mcsma, thanks for the report! I'm reviewing the PR now

@mcsma
Copy link

mcsma commented May 7, 2024

Thanks @orediggerco and thanks @MArmourTCCC for the effort on making it work on symfony7!

In the meantime I found an article on how to require the PR branch from @MArmourTCCC:

In the composer.json add the following:

"require": {
    "comcast/php-legal-licenses": "dev-add-support-for-symfony-7"
}

…as well as the redirect where the specific PR branch is found:

"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/MArmourTCCC/php-legal-licenses.git",
        "only": ["comcast/php-legal-licences"]
    }
]

… and finally run composer update comcast/php-legal-licenses.

Source: https://stackoverflow.com/a/55307273

@orediggerco
Copy link
Member

PR #25 has been merged. Thanks @MArmourTCCC and @mcsma !

@mcsma
Copy link

mcsma commented May 7, 2024

Thank you sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants