Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core probably should not use context.Context #13

Open
jsccast opened this issue Jan 23, 2018 · 2 comments
Open

Core probably should not use context.Context #13

jsccast opened this issue Jan 23, 2018 · 2 comments

Comments

@jsccast
Copy link
Member

jsccast commented Jan 23, 2018

context.Context depends (indirectly) on fmt and bunch of other stuff. To keep core small, remove that explicit context dependency by introducing a local Context type that satisfies the right interface.

@jsccast
Copy link
Member Author

jsccast commented Jan 23, 2018

Also consider not using campoy/jsonenums because that code also pulls in fmt.

@jsccast
Copy link
Member Author

jsccast commented Jan 23, 2018

encoding.json of course depends on fmt, and removing our dependency on encoding.json -- though small -- isn't easy. (Spec.PatternSyntax == "json" is just a bit too convenient to have right there. At least for now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant