Configure number of synchronised products in Channel configuration #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +33,12 @@ public function __invoke(SynchronizationEnded $event): void | |||
| Assert::allIsInstanceOf($products, BoughtTogetherProductsAwareInterface::class); | |||
|
|
|||
| foreach ($products as $product) { | |||
There was a problem hiding this comment.
Since there can be a lot of products, it would be nice to flush every x products besides the one after all.
| $numberOfProducts = max($numberOfProducts, $channel->getNumberOfSynchronisedProducts()); | ||
| } | ||
|
|
||
| if ($numberOfProducts === 0) { |
There was a problem hiding this comment.
Suggested change
| if ($numberOfProducts === 0) { | |
| if ($numberOfProducts <= 0) { |
Covering an edge case
coldic3
reviewed
Apr 9, 2024
| @@ -5,3 +5,8 @@ sylius_ui: | |||
| commerce_weavers_sylius_also_bought_missing_configuration: | |||
| template: '@CommerceWeaversSyliusAlsoBoughtPlugin/_missing_configuration.html.twig' | |||
| priority: 40 | |||
| sylius.admin.channel.form.second_column_content: | |||
| blocks: | |||
| commerce_weavers_sylius_also_bought_number_of_synchronised_products: | |||
There was a problem hiding this comment.
Suggested change
| commerce_weavers_sylius_also_bought_number_of_synchronised_products: | |
| commerce_weavers_sylius_also_bought_number_of_synchronized_products: |
just because in different places, we already use the US version with z
There was a problem hiding this comment.
same for twig tempalte file name etc.
| @@ -0,0 +1,22 @@ | |||
| @managing_channels | |||
| Feature: Managing number of items on channel | |||
There was a problem hiding this comment.
It's not detailed enough IMHO. I'd specify which items eg. Managing number of items to synchronize on channel
| { | ||
| /** @ORM\Column(name="number_of_synchronised_products", type="integer", nullable=false, options={"default": 10}) */ | ||
| #[ORM\Column(name: 'number_of_synchronised_products', type: 'integer', nullable: false, options: ['default' => 10])] | ||
| private int $numberOfSynchronisedProducts = 10; |
There was a problem hiding this comment.
Suggested change
| private int $numberOfSynchronisedProducts = 10; | |
| private int $numberOfSynchronizedProducts = 10; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
TODO: