Position issue onClick when using headers

[Fuhrmann]

Thanks again for helping me on the last issue. This is how I'm setting up the modal:

implementation 'com.github.Commit451:ModalBottomSheetDialogFragment:1.0.0'

my_modal_menu,xml

<?xml version="1.0" encoding="utf-8"?>
<menu xmlns:android="http://schemas.android.com/apk/res/android">
    <item
        android:id="@+id/action_view"
        android:icon="@drawable/ic_view"
        android:title="View" />

    <item
        android:id="@+id/action_delete"
        android:icon="@drawable/ic_delete"
        android:title="Delete" />
</menu>

Then, I add a header to my modal and add the menu:

ModalBottomSheetDialogFragment.Builder()
    .add(R.menu.my_modal_menu)
    .header("Pick an option")
    .show(childFragmentManager, "my_modal")

The bottom modal shows up, but is throwing an throwIndexOutOfBoundsException

java.lang.IndexOutOfBoundsException: Invalid index 2, size is 2
        at java.util.ArrayList.throwIndexOutOfBoundsException(ArrayList.java:255)
        at java.util.ArrayList.get(ArrayList.java:308)
        at com.commit451.modalbottomsheetdialogfragment.ModalBottomSheetDialogFragment$Adapter$onCreateViewHolder$1.onClick(ModalBottomSheetDialogFragment.kt:212)

So I went and debugged and we got this:

When I'm pressing the second option on the bottom sheet modal, you get the adapterPosition which you can see below is 2.

But the problem is I only have two options, position 0 and 1:

Then the error is thrown. Maybe it has something to do to the fact I'm using a header so the adapterPosition is 2 because the header is 0?

Thanks!

[TJBlack31]

I'm pretty sure I have this issue tackled. This is my first open-source contribution. Bear with me lol.

[TJBlack31]

It's fixed and a new pull request has been added.

Thank you for the opportunity 👍

[Fuhrmann]

Nice! Good to know you fixed! Thanks for your contribution in the open source world! 😄

[Jawnnypoo]

Fixed this as 1.0.1, thanks again @TJBlack31 for the fix and @Fuhrmann for reporting!