NPE in workspace deletion

[pkocandr]

When I try to delete an existing workspace I get NPE:

21:56:48.761 [vert.x-eventloop-thread-2] INFO  o.c.aprox.bind.vertx.RestRouter - REQUEST>>> DELETE /depgraph/ws/1393620479043

[vert.x-eventloop-thread-2] INFO  o.c.aprox.bind.vertx.RestRouter - REQUEST>>> DELETE /depgraph/ws/1393620479043

21:56:48.762 [vert.x-eventloop-thread-2] INFO  o.c.aprox.bind.vertx.RestRouter - MATCH: Route [DELETE /depgraph/ws/:wsid] => /depgraph/ws

[vert.x-eventloop-thread-2] INFO  o.c.aprox.bind.vertx.RestRouter - MATCH: Route [DELETE /depgraph/ws/:wsid] => /depgraph/ws

21:56:48.762 [vert.x-eventloop-thread-2] INFO  o.c.aprox.bind.vertx.RestRouter - PARAM wsid = 1393620479043
[vert.x-eventloop-thread-2] INFO  o.c.aprox.bind.vertx.RestRouter - PARAM wsid = 1393620479043
21:56:48.762 [vert.x-eventloop-thread-2] INFO  o.c.vertx.vabr.util.AnnotationUtils - Searching org.commonjava.aprox.depgraph.vertx.WorkspaceResource for @Handles annotation...
[vert.x-eventloop-thread-2] INFO  o.c.vertx.vabr.util.AnnotationUtils - Searching org.commonjava.aprox.depgraph.vertx.WorkspaceResource for @Handles annotation...
21:56:48.762 [vert.x-eventloop-thread-2] INFO  o.c.vertx.vabr.util.AnnotationUtils - Got: /depgraph/ws
[vert.x-eventloop-thread-2] INFO  o.c.vertx.vabr.util.AnnotationUtils - Got: /depgraph/ws
21:56:48.762 [vert.x-eventloop-thread-2] INFO  o.c.a.d.v.Routes$BodyHandler_WorkspaceResource_delete_ - Attaching this as body handler.
[vert.x-eventloop-thread-2] INFO  o.c.a.d.v.Routes$BodyHandler_WorkspaceResource_delete_ - Attaching this as body handler.
Exception in thread "vertx-raw-dispatch-0" java.lang.NullPointerException
    at java.io.File.<init>(File.java:360)
    at org.commonjava.maven.atlas.graph.spi.neo4j.FileNeo4jWorkspaceFactory.deleteWorkspace(FileNeo4jWorkspaceFactory.java:62)
    at org.commonjava.maven.atlas.graph.EGraphManager.deleteWorkspace(EGraphManager.java:199)
    at org.commonjava.maven.cartographer.data.DefaultCartoDataManager.deleteWorkspace(DefaultCartoDataManager.java:846)
    at org.commonjava.maven.cartographer.data.DefaultCartoDataManager$Proxy$_$$_WeldClientProxy.deleteWorkspace(Unknown Source)
    at org.commonjava.maven.cartographer.ops.WorkspaceOps.delete(WorkspaceOps.java:56)
    at org.commonjava.maven.cartographer.ops.WorkspaceOps$Proxy$_$$_WeldClientProxy.delete(Unknown Source)
    at org.commonjava.aprox.depgraph.rest.WorkspaceController.delete(WorkspaceController.java:59)
    at org.commonjava.aprox.depgraph.rest.WorkspaceController$Proxy$_$$_WeldClientProxy.delete(Unknown Source)
    at org.commonjava.aprox.depgraph.vertx.WorkspaceResource.delete(WorkspaceResource.java:69)
    at org.commonjava.aprox.depgraph.vertx.WorkspaceResource$Proxy$_$$_WeldClientProxy.delete(Unknown Source)
    at org.commonjava.aprox.depgraph.vertx.Routes$BodyHandler_WorkspaceResource_delete_.run(Routes.java:2874)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:744)

Actually I've tried it only in aprox-launcher-savant 0.11.3, so not sure if the problem also exist somewhere else.

[jdcasey]

Filed jdcasey/atlas#9 to investigate whether it's a problem in the graph driver.

[jdcasey]

From the log, it seems like the data basedir (normally /var/lib/aprox/db or /data) is not configured, but I'd have to see the system and its configuration to know for sure.

[jdcasey]

This looks like it's related to the aprox configuration loader running twice at boot. I'm still trying to work out why that might be happening, though...

[pkocandr]

Just noticed a warning in log

16:48:23.967 [vertx-raw-dispatch-0] WARN  o.neo4j.kernel.EmbeddedGraphDatabase - You are using an unsupported Java runtime. Please use Oracle(R) Java(TM) Runtime Environment 7.

I wonder if that's related.

[jdcasey]

https://groups.google.com/forum/#!topic/neo4j/2Jntfsyodws

I wonder if some of those concerns about performance have anything to do with your experiences with OOME?

BTW, I tracked down the NPE I was seeing, and it was a hidden error related to deserialization of the old repository definitions using the new code (0.12.0-SNAPSHOT). I've got that fixed, and I'll make sure it's pushed.