Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify FileResourceStore on Windows #61

Closed
joachimvh opened this issue Aug 18, 2020 · 2 comments
Closed

Verify FileResourceStore on Windows #61

joachimvh opened this issue Aug 18, 2020 · 2 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@joachimvh
Copy link
Member

Currently all FileResourceStore tests work on Windows, due to the usage of path.posix, as was fixed in b489d69, but I should have a deeper look to see if it actually works when writing real files.

@joachimvh joachimvh added the 🐛 bug Something isn't working label Aug 18, 2020
@joachimvh joachimvh self-assigned this Aug 18, 2020
@RubenVerborgh
Copy link
Member

@joachimvh
Copy link
Member Author

Tests in #154 also work on Windows so this is resolved.

I tried adding Windows to travis but the builds seem to get stuck after finishing (example here).

Done. Your build exited with 0.

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

The build has been terminated

This might be because of the validation script that sets up a server and maybe doesn't close correctly on windows, but as long as it is this easy for it to get stuck I wouldn't rely on it for testing (especially since it doubles the amount of tests for travis and they take quite a bit longer than the linux tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants