Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsalProvider constructor crashes unless you pass scopes #195

Open
asklar opened this issue Aug 15, 2022 · 1 comment
Open

MsalProvider constructor crashes unless you pass scopes #195

asklar opened this issue Aug 15, 2022 · 1 comment

Comments

@asklar
Copy link

asklar commented Aug 15, 2022

public MsalProvider(IPublicClientApplication client, string[] scopes = null, bool autoSignIn = true)

the default value for scopes is null, but we unconditionally run the Select(...) on it. Fix would be to either not provide a default argument for scopes (since it's arguably needed), or at least use scopes?.Select(...) so that we don't end up with a null deref.
note there's 2 ctors with this issue

@ghost ghost added the needs triage 🔍 label Aug 15, 2022
@ghost
Copy link

ghost commented Aug 15, 2022

Hello asklar, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants