Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce code styling and editor config #33

Closed
Arlodotexe opened this issue Feb 11, 2022 · 4 comments · Fixed by #60
Closed

Enforce code styling and editor config #33

Arlodotexe opened this issue Feb 11, 2022 · 4 comments · Fixed by #60
Assignees

Comments

@Arlodotexe
Copy link
Member

The Labs repo is using default settings for code styling and .editorconfig. We need to bring in the .editorconfig and other code styling analyzers from the main repo.

@michael-hawker michael-hawker self-assigned this Mar 30, 2022
@michael-hawker
Copy link
Member

Reading more, looks like .editorconfig should handle most of our needs these days. It should be able to specify stuff in the IDE, but also in our CI.

Resources for CI enforcement:

https://docs.microsoft.com/en-us/visualstudio/code-quality/use-roslyn-analyzers?view=vs-2022#command-line-usage
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/overview#enable-on-build

Info on running XAML Styler on commit here as well: https://github.com/Xavalon/XamlStyler/wiki/Git-Hook

Looking at seeing if I can add this stuff in, so assigning to myself.

@michael-hawker
Copy link
Member

Investigated looking at a tools manifest to help us with things: https://docs.microsoft.com/en-us/dotnet/core/tools/local-tools-how-to-use

And of course the Git Hooks docs: https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks

@michael-hawker
Copy link
Member

Script integration info for XAML Styler: https://github.com/Xavalon/XamlStyler/wiki/Script-Integration

Though running into some issues getting it to run.

@Jay-o-Way
Copy link
Contributor

FYI: the nugget wasn't updated for a while, but v3.2311.2 has been published about two hours ago
Xavalon/XamlStyler#429 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants