[Closed] Extend ColorAnimationExtensions with generic 'ColorTo' extension

[PieEatingNinjas]

Currently the ColorAnimationExtensions class has 1 method BackgroundColorTo which helps animating the color transition of a VisualElement's BackgroundColor.

We could (relatively) easily make this method more generic so we can use it for other properties of type Color on VisualElements as well.

For example:
label.ColorTo(l => l.TextColor, color, rate, duration, easing);
Where the first parameter identifies which property of type Color to update/animate. This parameter is of type Expression<Func<T, Color>>

Is this something that would be desired for the Toolkit? I'd think that animating the TextColor of a Label for example is something devs might want.

This ColorTo method doesn't need to replace the existing BackgroundColorTo method, as the generic ColorTo is a bit more complex to use because of the extra parameter. Plus, the existing BackgroundColorTo will be more efficient compared to ColorTo where you would need to pass-in the BackgroundColor property. So both can live side by side.
Alternatively, we could overload the ColorTo method, one with the new parameter and one without, where the last one updates the BackgroundColor (== current implementation of BackgroundColorTo)

Let's discuss! 🙂

[brminnick]

I like where this idea is going!

The implementation is a little tough to infer for new users, though. I.e. If I saw this method in intellisense, would I know how to use it without looking at the documentation?

Task ColorTo(this VisualElement, Func<T, Color> colorProperty, Color color, uint rate, uint duration, Easing easing)

Probably not; I'd certainly be confused by the point of the Func.

Proposal: Extend ITextStyle

What if we extend ITextStyle instead?

Task TextColorTo(this ITextStyle, Color color, uint rate = 16, uint duration = 250, Easing? easing = null);

This would allow us to use it for any UI control that implements ITextStyle, like ILabel, IButton, IEntry, etc.

var label = new Label();
await label.TextColorTo(Colors.Red, 16, 1500, Easing.SinIn);

var button = new TextButton();
await button.TextColorTo(Colors.Green, 16, 1500);

var entry = new Entry();
await entry.TextColorTo(Colors.Pink);

[PieEatingNinjas]

I totally understand that the method signature might not be intuitive.
Your proposal is indeed a lot more clear! I have to admit I'm not yet accustomed to the new MAUI interfaces...😅 It would make a lot more sense to go that direction.

[brminnick]

Right on!

When you get a chance, open a new discussion for ITextStyle. I'd be happy to champion this feature 💯

And it's probably not a bad idea to peruse the other interfaces to see if there are any other interfaces that also use Color that we can add an extension method for too!

[PieEatingNinjas]

At first glance, I found properties of type Color on the following interfaces:

• IActivityIndicator
• IPicker
• IPlaceholder
• IProgress
• ISearchBar
• ISlider
• ISwitch
• ITextStyle

How do you want to go forward with this? Do I already create a new discussion specific for adding an extension method for ITextStyle? Or do you want me to create one discussion where we discuss adding extensions all of the above interfaces?

[brminnick]

Let's break them up into separate discussions. Otherwise we'd have to implement them all in the same PR, and once we add the implementation, samples and unit tests it'd be a massive PR.

[CliffAgius]

Closed as answered.