Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Ship ReadMe.txt file with packages to inform consumers of necessary steps #273

Closed
2 of 10 tasks
bijington opened this issue Feb 2, 2022 · 7 comments · Fixed by #308
Closed
2 of 10 tasks
Assignees
Labels
approved This Proposal has been approved and is ready to be added to the Toolkit champion A member of the .NET MAUI Toolkit core team has chosen to champion this feature documentation approved in-progress proposal A fully fleshed out proposal describing a new feature in syntactic and semantic detail
Milestone

Comments

@bijington
Copy link
Contributor

bijington commented Feb 2, 2022

[FEATURE_NAME] Ship ReadMe.txt file with packages to inform consumers of necessary steps

  • Proposed
  • Prototype
  • Implementation: Not Started
    • iOS Support
    • Android Support
    • macOS Support
    • Windows Support
  • Unit Tests: Not Started
  • Sample: Not Started
  • Documentation: Not Started

Link to Discussion

This is being raised as a result of discussion #272 where the consumer saw that using a converter in XAML only was reporting build issues.

Summary

Add a README.txt to the NuGet Package that provide guidance to consumers on how to Use the toolkit upon installation.

The Getting Started step should detail the extension method usage to initialise the library:

builder.UseMauiApp<App>().UseMauiCommunityToolkit();

And then refer the developer on to the docs website for further details.

Also add the Getting Started steps to the GitHub Repository README.md, along with a NuGet Package badge:

NuGet

Motivation

To make it easier to get going in using the toolkit packages.

Detailed Design

It should involve the addition of a readme.txt to each project and then adding this line to each project:

<None Include="readme.txt" pack="true" PackagePath="." />

Usage Syntax

N/A

Drawbacks

We would need to cover what happens if both CommunityToolkit.Maui and CommunityToolkit.Maui.Core are added. We don't need to inform the user they need to use both methods.

Alternatives

Do nothing? Leave it in the documentation online.

Unresolved Questions

@bijington bijington added new proposal A fully fleshed out proposal describing a new feature in syntactic and semantic detail labels Feb 2, 2022
@ghost ghost added this to Proposal Submitted in New Feature Proposals Feb 2, 2022
@brminnick brminnick moved this from Proposal Submitted to Proposal Championed in New Feature Proposals Feb 2, 2022
@brminnick
Copy link
Collaborator

brminnick commented Feb 2, 2022

Thanks Shaun! Love this idea to help devs get up and running quickly with the .NET MAUI Community Toolkit! 💯

As a part of this effort, could we also add the Getting Started info to our GitHub Repository README.md too?

We can put the Getting Started info in the top of the README.md before the Submitting a New Feature section, along with a NuGet Package badge:

NuGet

Getting Started

// ...

@brminnick brminnick moved this from Proposal Championed to Proposal Submitted in New Feature Proposals Feb 2, 2022
@brminnick brminnick moved this from Proposal Submitted to Proposal Championed in New Feature Proposals Feb 2, 2022
@ghost ghost added champion A member of the .NET MAUI Toolkit core team has chosen to champion this feature and removed new labels Feb 2, 2022
@bijington
Copy link
Contributor Author

Yes great idea!

@bijington bijington moved this from Proposal Championed to Proposal Approved in New Feature Proposals Feb 3, 2022
@ghost ghost added approved This Proposal has been approved and is ready to be added to the Toolkit help wanted This proposal has been approved and is ready to be implemented labels Feb 3, 2022
@bijington bijington removed the help wanted This proposal has been approved and is ready to be implemented label Feb 3, 2022
@ghost
Copy link

ghost commented Mar 7, 2022

Reopening Proposal.

Only Proposals moved to the Closed Project Column and Completed Project Column can be closed.

@ghost ghost reopened this Mar 7, 2022
@brminnick brminnick moved this from Proposal Approved to Completed in New Feature Proposals Mar 7, 2022
@ghost ghost closed this as completed Mar 7, 2022
@brminnick brminnick added this to the v1.0.0 milestone Apr 15, 2022
@ghost ghost reopened this Apr 15, 2022
@ghost
Copy link

ghost commented Apr 15, 2022

Reopening Proposal.

Only Proposals moved to the Closed Project Column and Completed Project Column can be closed.

@VladislavAntonyuk
Copy link
Collaborator

I think we can move it to completed

@ghost
Copy link

ghost commented Apr 20, 2022

Reopening Proposal.

Only Proposals moved to the Closed Project Column and Completed Project Column can be closed.

@ghost ghost reopened this Apr 20, 2022
@bijington bijington moved this from Completed to Pull Request Approved (Pending Documentation) in New Feature Proposals Apr 20, 2022
@bijington bijington moved this from Pull Request Approved (Pending Documentation) to Completed in New Feature Proposals Apr 20, 2022
@ghost ghost closed this as completed Apr 20, 2022
@bijington
Copy link
Contributor Author

thanks @VladislavAntonyuk msftbot seemed to want to keep it open for some reason 🤷

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This Proposal has been approved and is ready to be added to the Toolkit champion A member of the .NET MAUI Toolkit core team has chosen to champion this feature documentation approved in-progress proposal A fully fleshed out proposal describing a new feature in syntactic and semantic detail
Projects
Development

Successfully merging a pull request may close this issue.

3 participants