Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataGrid Style #4900

Open
BenjaminTGa opened this issue Jun 23, 2023 · 5 comments
Open

Update DataGrid Style #4900

BenjaminTGa opened this issue Jun 23, 2023 · 5 comments
Labels
DataGrid 🔠 Issues on DataGrid control improvements ✨

Comments

@BenjaminTGa
Copy link

BenjaminTGa commented Jun 23, 2023

Describe the problem

I have discovered that the DataGrid component follows WinUI 3 (or Windows 11) styling. It doesn't look great, and really clashes with the look of my WinUI 3 app. Given that this is only grid component that can be used for WinUI 3 apps, I feel it's important to make it match the aesthetics of WinUI 3.

Describe the solution

I think that a new version of the DataGrid could be made, maybe called WinUI3DataGrid, or Win11DataGrid, or that the original DataGrid component could be renamed LegacyDataGrid and the new one called DataGrid.

Alternatives

No response

Additional info

No response

Help us help you

Yes, but only if others can assist.

I'm not great with WinUI 3, but I can to really basic stuff. So I guess I should say: Yes, but only if others can assist and it's really easy.

@BenjaminTGa BenjaminTGa added the feature request 📬 A request for new changes to improve functionality label Jun 23, 2023
@ghost
Copy link

ghost commented Jun 23, 2023

Hello, 'BenjaminTGa! Thanks for submitting a new feature request. I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future!

@michael-hawker
Copy link
Member

@BenjaminTGa see the work we're doing in CommunityToolkit/Labs-Windows#415

I also think you mean Windows 10 style? In either case, we wouldn't create a new control, but just update the existing style or create an alternate.

Though, we don't have plans in the near future to work on this component. It won't be part of our initial migration to the new repository at https://github.com/CommunityToolkit/Windows

@michael-hawker michael-hawker added improvements ✨ DataGrid 🔠 Issues on DataGrid control and removed feature request 📬 A request for new changes to improve functionality labels Jul 14, 2023
@michael-hawker michael-hawker changed the title [Feature] WinUI 3 styled DataGrid Update DataGrid Style Jul 14, 2023
@michael-hawker
Copy link
Member

@niels9001 I think you did some poking here for TemplateStudio, should we dump that style in a gist for now?

@BenjaminTGa
Copy link
Author

@BenjaminTGa see the work we're doing in CommunityToolkit/Labs-Windows#415

I also think you mean Windows 10 style? In either case, we wouldn't create a new control, but just update the existing style or create an alternate.

Though, we don't have plans in the near future to work on this component. It won't be part of our initial migration to the new repository at https://github.com/CommunityToolkit/Windows

Yes, I do mean the Windows 10 style. Most of the Windows Community Toolkit widgets follow that look, but, as I said before, it's the only grid component WinUI 3 has so it's important for it to follow WinUI 3 styling.

@BenjaminTGa
Copy link
Author

Looks good for the link you provided (Labs Windows). Just wondering how ready it is to be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataGrid 🔠 Issues on DataGrid control improvements ✨
Projects
None yet
Development

No branches or pull requests

2 participants