Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win2D Path Mini Parser: decimal separator localization bug #4901

Open
3 of 14 tasks
dongle-the-gadget opened this issue Jun 26, 2023 · 2 comments
Open
3 of 14 tasks

Win2D Path Mini Parser: decimal separator localization bug #4901

dongle-the-gadget opened this issue Jun 26, 2023 · 2 comments
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior

Comments

@dongle-the-gadget
Copy link

dongle-the-gadget commented Jun 26, 2023

Describe the bug

When the user uses the English (United States) locale but change their decimal separator to use anything other than a dot, Win2D Path Mini Parser generates the wrong code.

Regression

No response

Reproducible in sample app?

  • This bug can be reproduced in the sample app.

Steps to reproduce

1. Change the decimal separator in the Control Panel Region Applet
2. Open the Sample App.
3. Go to Helpers > Win2D Path Mini Language Parser
4. Click on any of the samples (i.e., Rounded Star)
5. Observe the Canvas tab showing nothing, and the wrong code being generated in the Commands tab.

Expected behavior

The Canvas tab should show the correct glyphs and the Commands tab should show the correct code being generated, regardless of the user's decimal settings.

Screenshots

image image

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

23481 and 23486

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

10.0.22621.0

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

Desktop

Nuget packages

Microsoft.Toolkit.Uwp.UI.Media 7.1.3

Additional context

Wrong path for Rounded Star in English United States + comma as decimal separator:
https://gist.github.com/dongle-the-gadget/16d4112792a56a175008d48e058dbd53

Correct reference path from default locale settings:
https://pastebin.com/raw/fwMPkfKp

From my observation, it seems that the decimal point was entirely missing.

[Unrelated to the problem but worthy to mention: the suffix "f" for float is also missing]

Help us help you

Yes, I'd like to be assigned to work on this item.

@dongle-the-gadget dongle-the-gadget added the bug 🐛 An unexpected issue that highlights incorrect behavior label Jun 26, 2023
@ghost ghost added the needs triage 🔍 label Jun 26, 2023
@ghost
Copy link

ghost commented Jun 26, 2023

Hello dongle-the-gadget, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@ghost ghost added the needs attention 👋 label Jul 11, 2023
@ghost
Copy link

ghost commented Jul 11, 2023

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior
Projects
None yet
Development

No branches or pull requests

2 participants