Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BactrianUpDownOperator modifies the wrong index when elementWise is true #1126

Closed
bjoelle opened this issue Sep 12, 2023 · 1 comment
Closed

Comments

@bjoelle
Copy link

bjoelle commented Sep 12, 2023

l95 and l105 have this code p.setValue(p.getValue(index) * scale); which as far as I can tell will modify the value at position 0 regardless of what index is set to
the equivalent code in UpDown operator is p.setValue(index, p.getValue(index) * scale); as expected

@rbouckaert
Copy link
Member

Good point! Should be fixed by c9862c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants