Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magic code in initAndValidate #21

Closed
tgvaughan opened this issue Jan 19, 2014 · 2 comments
Closed

magic code in initAndValidate #21

tgvaughan opened this issue Jan 19, 2014 · 2 comments

Comments

@tgvaughan
Copy link
Member

The initAndValidate() for the CalibratedYuleModel class contains this code:

        if (nCals == 0) {
            // assume we are in beauti, back off for now
            return;
        }

Is this really the best BEAST2 can do for developers. How can a developer know if this magic is needed, and where? if there is no alternative, this must be very prominently and thoroughly documented.

@ghost ghost assigned jheled Jan 19, 2014
@rbouckaert
Copy link
Member

Merge with issue #25

@rbouckaert
Copy link
Member

Close since this is duplicate of #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants