Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to sets #162

Merged
merged 8 commits into from Sep 5, 2022
Merged

Convert to sets #162

merged 8 commits into from Sep 5, 2022

Conversation

nwlandry
Copy link
Collaborator

Converted all instances of edges to sets from lists in response to #158. Changed unit tests to reflect this.

leotrs
leotrs requested changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@leotrs leotrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking the lead on this one! Does this depend on #161 ?

tests/classes/test_hypergraph.py Outdated Show resolved Hide resolved
tests/test_convert.py Show resolved Hide resolved
@nwlandry nwlandry requested a review from leotrs September 1, 2022 15:27
@nwlandry
Copy link
Collaborator Author

nwlandry commented Sep 1, 2022

This does kinda change #161, but this seems more important so I would like to merge this first.

@nwlandry nwlandry linked an issue Sep 2, 2022 that may be closed by this pull request
Coerce all edges to sets #158
Closed
@nwlandry nwlandry merged commit 1556c05 into main Sep 5, 2022
@nwlandry nwlandry deleted the convert-to-sets branch September 5, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leotrs leotrs leotrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coerce all edges to sets
2 participants
@nwlandry @leotrs