Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Contest test instead of Fedora project beakerlib tests #11419

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Jan 5, 2024

Description:

Switch Fedora project tests to Contest.

Rationale:

Current Fedora project beakerlib tests fail very often and we do not maintain those tests anymore because of newer and better implementation in Contest.

Review Hints:

See Testing Farm results.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 5, 2024
@mildas mildas marked this pull request as draft January 5, 2024 08:47
Copy link

github-actions bot commented Jan 5, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Feb 28, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11419
This image was built from commit: 5477182

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11419

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11419 make deploy-local

@mildas
Copy link
Contributor Author

mildas commented Mar 15, 2024

/packit retest-failed

1 similar comment
@mildas
Copy link
Contributor Author

mildas commented Mar 15, 2024

/packit retest-failed

@mildas mildas changed the title [WIP] Run Contest test instead of Fedora project beakerlib tests Run Contest test instead of Fedora project beakerlib tests Mar 15, 2024
@mildas mildas marked this pull request as ready for review March 15, 2024 13:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 15, 2024
@comps
Copy link
Collaborator

comps commented Mar 15, 2024

LGTM, but someone else will have to actually review/merge this here in CaC/content.

Copy link

codeclimate bot commented Mar 15, 2024

Code Climate has analyzed commit 5477182 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

@mildas
Copy link
Contributor Author

mildas commented Mar 15, 2024

/packit retest-failed

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, LGTM.

@Mab879 Mab879 added this to the Backlog milestone Mar 15, 2024
@Mab879 Mab879 added the Infrastructure Our content build system label Mar 15, 2024
@Mab879 Mab879 self-assigned this Mar 15, 2024
@Mab879 Mab879 merged commit e1debb9 into ComplianceAsCode:master Mar 15, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants