Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ubuntu remediation for smartcard_pam_enabled #11489

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Jan 26, 2024

Description:

  • Fix Ubuntu remediation for rule smartcard_pam_enabled to correctly position pam_pkcs11 module in stack.

Rationale:

  • The line auth [success=2 default=ignore] pam_pkcs11.so is incorrectly inserted at the bottom of the pam file instead of above pam_unix.so. Solution is to use another macro, which supports appending lines after a specific match.

The line `auth    [success=2 default=ignore] pam_pkcs11.so`
is incorrectly inserted at the bottom of the pam file instead
of above `pam_unix.so`. Solution is to use another macro,
which supports appending lines after a specific match.
Copy link

openshift-ci bot commented Jan 26, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 26, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

sle12 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Jan 26, 2024

Code Climate has analyzed commit d344a0c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added SLES SUSE Linux Enterprise Server product related. Ubuntu Ubuntu product related. labels Jan 29, 2024
@dodys dodys requested a review from a team January 29, 2024 10:52
@dodys dodys self-assigned this Jan 29, 2024
@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Jan 29, 2024
@dodys
Copy link
Contributor

dodys commented Jan 29, 2024

@teacup-on-rockingchair could you check the error in the tests, it seems unrelated to the PR, but it would be good for you to confirm it.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@dodys
Copy link
Contributor

dodys commented Feb 1, 2024

The SLES issues seem unrelated to this PR and they should take a look on their side.

@dodys dodys merged commit 76eb7c6 into ComplianceAsCode:master Feb 1, 2024
41 of 46 checks passed
@Mab879 Mab879 added this to the 0.1.73 milestone Feb 1, 2024
@Mab879 Mab879 added the Bash Bash remediation update. label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants