Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve github workflow for building OCP PR image #11492

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

Vincent056
Copy link
Contributor

Make it so external contributors can have PR image built and pushed to GitHub image registry

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Vincent056 Vincent056 force-pushed the action_improve branch 4 times, most recently from 6a8795c to 9b4e183 Compare January 26, 2024 18:06
@marcusburghardt marcusburghardt added the OpenShift OpenShift product related. label Jan 29, 2024
@yuumasato yuumasato self-assigned this Jan 29, 2024
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vincent056 The action Kubernetes content image for PR is not running. Do you know why? Does this PR need to be merged for it to work?

.github/workflows/k8s-content-pr.yaml Show resolved Hide resolved
Make it so external contributor can have PR image built and pushed to github image registry
Copy link

codeclimate bot commented Jan 30, 2024

Code Climate has analyzed commit 3c59820 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.2% change).

View more on Code Climate.

@yuumasato yuumasato added this to the 0.1.73 milestone Jan 30, 2024
@yuumasato
Copy link
Member

Failures on Gate / Build, Test on Debian 10 (Container) (push) are unrelated, and seeem to be happening intermitently.

@yuumasato yuumasato merged commit 0df6b38 into master Jan 30, 2024
46 of 47 checks passed
@yuumasato yuumasato deleted the action_improve branch January 30, 2024 15:42
@Mab879 Mab879 added the Infrastructure Our content build system label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants