Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove prodtype from add_kubernetes_rule #11500

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

sluetze
Copy link
Contributor

@sluetze sluetze commented Jan 30, 2024

Description:

  • remove prodtype from add_kubernetes_rule

Rationale:

  • as prodtype was removed from the rules, new rules using the util should not add it again

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 30, 2024
Copy link

openshift-ci bot commented Jan 30, 2024

Hi @sluetze. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Jan 30, 2024

Code Climate has analyzed commit 37f7a12 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@yuumasato yuumasato self-assigned this Jan 30, 2024
@yuumasato yuumasato added this to the 0.1.73 milestone Jan 30, 2024
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this.
LGTM, just pending CI re-run.

@marcusburghardt marcusburghardt added the Kubernetes Kubernetes remediation update. label Jan 30, 2024
@yuumasato yuumasato merged commit 5f4e966 into ComplianceAsCode:master Jan 30, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kubernetes Kubernetes remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants