Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional updates in kernel_module_disabled template #11508

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

marcusburghardt
Copy link
Member

Description:

This PR complements the #11475.

Rationale:

Replace remaining occurrences of /bin/true in remediation.

It is not necessary to create another test scenario script but only
ensure at least one pass test scenario is using /bin/false instead of
/bin/true.
@marcusburghardt marcusburghardt added Bash Bash remediation update. Kubernetes Kubernetes remediation update. Update Rule Issues or pull requests related to Rules updates. labels Jan 30, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Jan 30, 2024
Copy link

codeclimate bot commented Jan 30, 2024

Code Climate has analyzed commit d1f9131 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.73 milestone Jan 30, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks

@Mab879 Mab879 merged commit 6880db4 into ComplianceAsCode:master Jan 30, 2024
42 of 43 checks passed
@marcusburghardt marcusburghardt deleted the kernel_module_false branch January 30, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. Kubernetes Kubernetes remediation update. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants