Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ubuntu remediation for pam_faildelay #11532

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fix ubuntu remediation for pam_faildelay #11532

merged 1 commit into from
Feb 2, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Feb 1, 2024

Description:

  • Fix ubuntu remediation for pam_faildelay by placing the module at beginning of stack

Rationale:

  • pam_faildelay module was placed at end of /etc/pam.d/common-auth, after various statements with success=die, sufficient and requisite, and was thus never reached

@mpurg
Fix ubuntu remediation for pam_faildelay
7a376e1 
pam_faildelay module was placed at end of /etc/pam.d/common-auth,
after various modules with success=die, sufficient and requisite,
and was thus never reached.

The solution is to place the module at beginning of file.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 1, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 1, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys requested a review from a team February 1, 2024 18:06
@dodys dodys self-assigned this Feb 1, 2024
@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Feb 1, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 1, 2024

Code Climate has analyzed commit 7a376e1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@dodys
Copy link
Contributor

dodys commented Feb 1, 2024

/packit retest-failed

dodys
dodys approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 04413ad into ComplianceAsCode:master Feb 2, 2024
39 of 42 checks passed
@Mab879 Mab879 added this to the 0.1.73 milestone Feb 6, 2024
@Mab879 Mab879 added the Bash Bash remediation update. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels
Bash Bash remediation update. ok-to-test Used by openshift-ci bot.
Projects
None yet
Milestone
0.1.73
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpurg @dodys @Mab879