Update entities/common.py to use CDumper #11541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
jan-cerny
approved these changes
Feb 5, 2024
| @@ -128,7 +133,8 @@ def derive_id_from_file_name(filename): | |||
|
|
|||
| def dump_yaml_preferably_in_original_order(dictionary, file_object): | |||
| try: | |||
| return yaml.dump(dictionary, file_object, indent=4, sort_keys=False) | |||
| return yaml.dump(dictionary, file_object, indent=4, sort_keys=False, | |||
There was a problem hiding this comment.
This is a nice improvement. I got a speed up about 6 seconds when building RHEL 9 content.
Can you investigate if this change can be consolidated with ssg/yaml.py?
There was a problem hiding this comment.
I updated to import yaml_Dumper from ssg/yaml.py.
Mab879
force-pushed
the
speedup_yaml_dumping
branch
from
a8cd509
to
507351e
Compare
|
Code Climate has analyzed commit 507351e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 66.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
|
/packit retest-failed |
jan-cerny
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update
ssg/entities/common.pyto useCDumper.Rationale:
Significant speed up of
compile_all.py.