Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHEL 9 support for playbook to role conversion utility #11542

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

dmc5179
Copy link
Contributor

@dmc5179 dmc5179 commented Feb 4, 2024

Description:

Add RHEL 9 support for playbook to role conversion utility.

Rationale:

The current ansible_playbook_to_role.py utility does not support the RHEL 9 playbooks that are part of this repository.
This PR adds support for the RHEL 9 playbooks and supports the change for new repositories from master to main.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 4, 2024
Copy link

openshift-ci bot commented Feb 4, 2024

Hi @dmc5179. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented Feb 4, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.73 milestone Feb 5, 2024
@Mab879 Mab879 self-assigned this Feb 5, 2024
@Mab879 Mab879 added the Infrastructure Our content build system label Feb 5, 2024
@Mab879
Copy link
Member

Mab879 commented Feb 5, 2024

/packit retest-failed

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I have couple of suggestions based on PEP8.

utils/ansible_playbook_to_role.py Outdated Show resolved Hide resolved
utils/ansible_playbook_to_role.py Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Feb 13, 2024

Code Climate has analyzed commit a5a3052 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 89a8eda into ComplianceAsCode:master Feb 13, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants