Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMP-2372: Remove info override for virtual syscall rules #11544

Merged

Conversation

rhmdnd
Copy link
Collaborator

@rhmdnd rhmdnd commented Feb 5, 2024

The STIG has controls that ensure virtual system calls are disabled,
because they pose a security risk. However, the rule was previously
overridden to always inform users, instead of actually checking the
functionality was disabled.

This commit removes the override so that we evaluate the kernel argument
appropriately. If a user still needs to disable this check (e.g., to
make it easier to run 32 bit applications) then they can still exclude
the rule using a TailoredProfile.

The STIG has controls that ensure virtual system calls are disabled,
because they pose a security risk. However, the rule was previously
overridden to always inform users, instead of actually checking the
functionality was disabled.

This commit removes the override so that we evaluate the kernel argument
appropriately. If a user still needs to disable this check (e.g., to
make it easier to run 32 bit applications) then they can still exclude
the rule using a TailoredProfile.
@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Feb 5, 2024

/test

Copy link

openshift-ci bot commented Feb 5, 2024

@rhmdnd: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test 4.13-images
  • /test 4.14-images
  • /test 4.15-images
  • /test 4.16-images
  • /test e2e-aws-ocp4-cis
  • /test e2e-aws-ocp4-cis-node
  • /test e2e-aws-ocp4-e8
  • /test e2e-aws-ocp4-high
  • /test e2e-aws-ocp4-high-node
  • /test e2e-aws-ocp4-moderate
  • /test e2e-aws-ocp4-moderate-node
  • /test e2e-aws-ocp4-pci-dss
  • /test e2e-aws-ocp4-pci-dss-node
  • /test e2e-aws-ocp4-stig
  • /test e2e-aws-ocp4-stig-node
  • /test e2e-aws-rhcos4-e8
  • /test e2e-aws-rhcos4-high
  • /test e2e-aws-rhcos4-moderate
  • /test e2e-aws-rhcos4-stig
  • /test images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-ComplianceAsCode-content-master-4.13-images
  • pull-ci-ComplianceAsCode-content-master-4.14-images
  • pull-ci-ComplianceAsCode-content-master-4.15-images
  • pull-ci-ComplianceAsCode-content-master-4.16-images
  • pull-ci-ComplianceAsCode-content-master-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Feb 5, 2024

/test e2e-aws-rhcos4-stig

@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Feb 5, 2024

/test e2e-aws-rhcos4-high
/test e2e-aws-rhcos4-moderate

Copy link

github-actions bot commented Feb 5, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Feb 5, 2024

Code Climate has analyzed commit cb6cd30 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

Copy link

openshift-ci bot commented Feb 5, 2024

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate cb6cd30 link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-rhcos4-high cb6cd30 link true /test e2e-aws-rhcos4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Feb 5, 2024

The RHCOS4 high and moderate profile failures are due to unrelated issues we're tracking in separate fixes.

@rhmdnd rhmdnd added the OpenShift OpenShift product related. label Feb 5, 2024
@rhmdnd rhmdnd requested a review from xiaojiey February 6, 2024 02:50
@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Feb 6, 2024

Adding @BhargaviGudi for review.

@BhargaviGudi
Copy link
Collaborator

/hold for test

@openshift-ci openshift-ci bot added the do-not-merge/hold Used by openshift-ci-robot bot. label Feb 7, 2024
@yuumasato yuumasato self-assigned this Feb 8, 2024
@yuumasato yuumasato added this to the 0.1.73 milestone Feb 8, 2024
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Just pending pre-merge tests.

@BhargaviGudi
Copy link
Collaborator

BhargaviGudi commented Feb 13, 2024

Verification passed with 4.16.0-0.nightly-2024-02-08-073857 + compliance-operator with compliance-operator code

Please find the testing details below

$ oc compliance bind -N test -S default-auto-apply profile/upstream-rhcos4-stig
Creating ScanSettingBinding test
$ oc get suite -w
NAME   PHASE     RESULT
test   RUNNING   NOT-AVAILABLE
test   RUNNING   NOT-AVAILABLE
test   AGGREGATING   NOT-AVAILABLE
test   AGGREGATING   NOT-AVAILABLE
test   DONE          COMPLIANT
test   DONE          COMPLIANT
$ oc get ccr | grep coreos-vsyscall-kernel-argument
upstream-rhcos4-stig-master-coreos-vsyscall-kernel-argument                                PASS     medium
upstream-rhcos4-stig-worker-coreos-vsyscall-kernel-argument                                PASS     medium

@BhargaviGudi
Copy link
Collaborator

/unhold
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Used by openshift-ci-robot bot. label Feb 13, 2024
@rhmdnd rhmdnd merged commit a7722d2 into ComplianceAsCode:master Feb 13, 2024
43 of 46 checks passed
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants