Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR workflow actions to run only on latest push #11616

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Vincent056
Copy link
Contributor

@Vincent056 Vincent056 commented Feb 22, 2024

Description:

Update all the PR-triggered workflows so they cancel previous action jobs in favor of new action jobs for the same PR when a new change is pushed

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Vincent056 Vincent056 changed the title Update github workflows PR runs Update PR workflow actions to run only on latest push Feb 22, 2024
Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11616

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11616

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11616 make deploy-local

Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so long as the maintainers of the other workflows are good with the change, too.

cc: @ggbecker

@Mab879 Mab879 added this to the 0.1.73 milestone Feb 27, 2024
@Mab879 Mab879 added the Infrastructure Our content build system label Feb 27, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks.

@Mab879
Copy link
Member

Mab879 commented Feb 27, 2024

/packit build

@Mab879
Copy link
Member

Mab879 commented Feb 27, 2024

However it seems that some the builds are stuck. @Vincent056 you may need to push again to get those to trigger.

@Vincent056
Copy link
Contributor Author

However it seems that some the builds are stuck. @Vincent056 you may need to push again to get those to trigger.

thanks for the review, just pushed again

@rhmdnd
Copy link
Collaborator

rhmdnd commented Feb 28, 2024

Looks like the Fedora builds are still stuck?

@Vincent056
Copy link
Contributor Author

/retest

Update all the PR-triggered workflows so they cancel previous action jobs for the same PR when a new change is pushed
Copy link

codeclimate bot commented Mar 4, 2024

Code Climate has analyzed commit 5b9fb2f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.8% (0.0% change).

View more on Code Climate.

@Vincent056 Vincent056 merged commit 1963d3c into ComplianceAsCode:master Mar 4, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants