Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the stable-profiles test #11617

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

jan-cerny
Copy link
Collaborator

We will add the following profiles to the stable-profiles test:

  • RHEL 7: CIS, PCI-DSS, STIG
  • RHEL 8: CIS
  • RHEL 9: CIS, PCI-DSS, STIG

The test will fail the CI if a rule is added or removed from a profile. That is especially useful for the profiles that are generated from control files that are shared among multiple profiles or products. The test become more relevant after the prodtype removal, because now the inclusion of rules to a data stream is driven only by profiles.

We will add the following profiles to the stable-profiles test:
- RHEL 7: CIS, PCI-DSS, STIG
- RHEL 8: CIS
- RHEL 9: CIS, PCI-DSS, STIG

The test will fail the CI if a rule is added or removed from a profile.
That is especially useful for the profiles that are generated from
control files that are shared among multiple profiles or products. The
test become more relevant after the prodtype removal, because now the
inclusion of rules to a data stream is driven only by profiles.
@jan-cerny jan-cerny added this to the 0.1.73 milestone Feb 22, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11617

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11617

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11617 make deploy-local

The login_banner_text variable is set multiple times but the setting
isn't always the same so it overrides each other. The value that
is consistent with each other is "cis_banners".
@jan-cerny jan-cerny requested a review from a team as a code owner February 22, 2024 13:00
Copy link

codeclimate bot commented Feb 22, 2024

Code Climate has analyzed commit a22323b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.1% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added the Infrastructure Our content build system label Feb 22, 2024
@Mab879 Mab879 self-assigned this Feb 22, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests work as expected.

@Mab879 Mab879 merged commit e0d5d7c into ComplianceAsCode:master Feb 22, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants