Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ANSSI requirement R69 for RHEL #11663

Merged
merged 8 commits into from
Mar 12, 2024

Conversation

vojtapolasek
Copy link
Collaborator

@vojtapolasek vojtapolasek commented Mar 7, 2024

Description:

  • add two similar rules which check for presence of obsolete services in /etc/nsswitch.conf
  • each rule has only OVAL check, as remediation should be done manually
  • services are NIS and Hesiod
  • the wording of the requirement is updated

Rationale:

  • ANSSI 2.0 alignment

@vojtapolasek vojtapolasek added New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. ANSSI ANSSI Benchmark related. labels Mar 7, 2024
@vojtapolasek vojtapolasek added this to the 0.1.73 milestone Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Mar 7, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11663
This image was built from commit: 592d94b

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11663

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11663 make deploy-local

@Mab879
Copy link
Member

Mab879 commented Mar 7, 2024

The failure on building the HTML seems suspicious, can you please investigate?

@jan-cerny
Copy link
Collaborator

The utils/gen_rendered_policies_index.py doesn't support jinja macros in control files, you need to change that because jinja macros should be allowed in control files.

@vojtapolasek
Copy link
Collaborator Author

The error while generating HTML pages is caused by the script gen_rendered_policies_index because it can't handle Jinja. Investigating...

@vojtapolasek
Copy link
Collaborator Author

I propose fix here: #11667

@Mab879 Mab879 self-assigned this Mar 8, 2024
@Mab879
Copy link
Member

Mab879 commented Mar 8, 2024

I merged #11667 so you should be able rebase this PR to resolve the CI issues.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few issues.

Thanks for the PR!

Co-authored-by: Matthew Burket <m@tthewburket.com>
@vojtapolasek
Copy link
Collaborator Author

Thank you for suggestions, applied.

Copy link

codeclimate bot commented Mar 12, 2024

Code Climate has analyzed commit 592d94b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.8% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 773ee95 into ComplianceAsCode:master Mar 12, 2024
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ANSSI ANSSI Benchmark related. New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants