Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections in aide_periodic_cron_checking and aide_scan_notification… #11665

Merged

Conversation

rumch-se
Copy link
Contributor

@rumch-se rumch-se commented Mar 8, 2024

… - SUSE products

Description:

  • _The proposed correction corrects 2 rules aide_periodic_cron_checking and aide_scan_notification _

Rationale:

SUSE SLE 12 and SLE 15 install aide in /usr/bin/aide, but both rules consider that the location is /usr/sbin/aide, following recommendations of DISA. This issue was addressed to DISA by SUSE.
Also there is an open discussion #11661. The proposed correction covers only SUSE products.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Mar 8, 2024
Copy link

openshift-ci bot commented Mar 8, 2024

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented Mar 8, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Mar 8, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11665
This image was built from commit: d0c9ad4

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11665

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11665 make deploy-local

@rumch-se rumch-se requested a review from a team as a code owner March 11, 2024 07:44
Copy link

codeclimate bot commented Mar 12, 2024

Code Climate has analyzed commit d0c9ad4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.8% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 🙇

@teacup-on-rockingchair teacup-on-rockingchair merged commit cbbca44 into ComplianceAsCode:master Mar 12, 2024
38 of 39 checks passed
@marcusburghardt marcusburghardt added the SLES SUSE Linux Enterprise Server product related. label Mar 13, 2024
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label May 16, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants