Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in ssg/build_derivatives.py #11666

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Mar 8, 2024

Description:

Doing a None check on cpe_list in ssg/build_derivatives.py.

In future versions

Rationale:

In future versions this might be an issue.

ssg/build_derivatives.py:49: FutureWarning: The behavior of this method will change in future versions. Use specific 'len(elem)' or 'elem is not None' test instead.

@Mab879 Mab879 added the Infrastructure Our content build system label Mar 8, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Mar 8, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11666
This image was built from commit: b6eb7ea

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11666

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11666 make deploy-local

Copy link

codeclimate bot commented Mar 8, 2024

Code Climate has analyzed commit b6eb7ea and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.8% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Mar 11, 2024
@jan-cerny jan-cerny merged commit 6b2df2c into ComplianceAsCode:master Mar 11, 2024
43 of 44 checks passed
@jan-cerny jan-cerny changed the title Fix deperation warning in ssg/build_derivatives.py Fix deprecation warning in ssg/build_derivatives.py Mar 11, 2024
@Mab879 Mab879 deleted the fix_build_derivatives_future branch March 11, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants