Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Blueprint for service_disabled template to mask services #11679

Conversation

evgenyz
Copy link
Member

@evgenyz evgenyz commented Mar 12, 2024

Description:

  • It is now aligned with other remediations.

Rationale:

Review Hints:

It is now aligned with other remediations.
@evgenyz evgenyz added Blueprint Image Builder Blueprint remediation update. osbuild Related in some way to Image Builder. labels Mar 12, 2024
@evgenyz evgenyz added this to the 0.1.73 milestone Mar 12, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11679
This image was built from commit: 4db3c97

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11679

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11679 make deploy-local

Copy link

codeclimate bot commented Mar 12, 2024

Code Climate has analyzed commit 4db3c97 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.8% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Mar 14, 2024
@jan-cerny jan-cerny merged commit bae1ded into ComplianceAsCode:master Mar 14, 2024
44 checks passed
@evgenyz evgenyz deleted the fix-blueprint-service-disabled-masked branch March 14, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blueprint Image Builder Blueprint remediation update. osbuild Related in some way to Image Builder.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from disabled to masked in the Blueprint remediation for service_disabled template
2 participants