Correction in oval part ensure_gpgcheck_globally_activated

[rumch-se]

Description:

• Correction in OVAL part of the rule ensure_gpgcheck_globally_activated

Rationale:

• According to DISA STIG for SUSE check should include that "gpgcheck" is not set to "0", "off", "no", or "false", because this is a finding.

[openshift-ci]

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[github-actions]

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11709
This image was built from commit: e5cff1f

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11709

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11709 make deploy-local

[jan-cerny]

This change looks wrong, there shouldn't be a literal s.

[rumch-se]

Hello @jan-cerny
I added 3 additional tests and fixed the issue with regexpr.
Have a nice day
Rumen

[codeclimate]

Code Climate has analyzed commit e5cff1f and detected 17 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Bug Risk	16
Style	1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (-0.5% change).

View more on Code Climate.

[jan-cerny]

/packit retest-failed

[jan-cerny]

/packit retest-failed

[jan-cerny]

The fail of Automatus job is caused by the fact that we test a RHEL 8 data stream on a Fedora container but Fedora differs from RHEL in the path of the package manager config file (/ect/dnf/dnf.conf vs /etc/yum.conf). If we execute the test locally against a VM back end, everything passes:

jcerny@fedora:~/work/git/scap-security-guide (pr/11709)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 ensure_gpgcheck_globally_activated
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2024-03-15-1025/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_ensure_gpgcheck_globally_activated
INFO - Script comment.fail.sh using profile (all) OK
INFO - Script correct_value.pass.sh using profile (all) OK
INFO - Script line_not_there.fail.sh using profile (all) OK
INFO - Script wrong_value.fail.sh using profile (all) OK
INFO - Script wrong_value_false.fail.sh using profile (all) OK
INFO - Script wrong_value_no.fail.sh using profile (all) OK
INFO - Script wrong_value_off.fail.sh using profile (all) OK
jcerny@fedora:~/work/git/scap-security-guide (pr/11709)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 --remediate-using ansible ensure_gpgcheck_globally_activated
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2024-03-15-1028/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_ensure_gpgcheck_globally_activated
INFO - Script comment.fail.sh using profile (all) OK
INFO - Script correct_value.pass.sh using profile (all) OK
INFO - Script line_not_there.fail.sh using profile (all) OK
INFO - Script wrong_value.fail.sh using profile (all) OK
INFO - Script wrong_value_false.fail.sh using profile (all) OK
INFO - Script wrong_value_no.fail.sh using profile (all) OK
INFO - Script wrong_value_off.fail.sh using profile (all) OK