Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CNSS REF URL #11714

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Remove CNSS REF URL #11714

merged 2 commits into from
Mar 15, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Mar 14, 2024

Description:

Remove CNSS REF URL from the product.

Rationale:

@Mab879 Mab879 added bugfix Fixes to reported bugs. Infrastructure Our content build system labels Mar 14, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Mar 14, 2024
@Mab879 Mab879 requested review from a team as code owners March 14, 2024 13:21
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11714
This image was built from commit: 70d1109

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11714

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11714 make deploy-local

@codeclimate CodeClimate
Copy link

codeclimate bot commented Mar 14, 2024

Code Climate has analyzed commit 70d1109 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.8% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 mentioned this pull request Mar 14, 2024
Closed
dodys
dodys approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

teacup-on-rockingchair
teacup-on-rockingchair approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no code, no problem 👍

marcusburghardt
marcusburghardt approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcusburghardt marcusburghardt self-assigned this Mar 15, 2024
@marcusburghardt
Copy link
Member

Overriding CODEOWNERS since a Oracle approver is not currently available.

@marcusburghardt
Copy link
Member

FYI @Xeicker

@marcusburghardt marcusburghardt merged commit 2d2bf88 into ComplianceAsCode:master Mar 15, 2024
44 checks passed
@Mab879 Mab879 deleted the remove_cnss_ref branch March 15, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teacup-on-rockingchair teacup-on-rockingchair teacup-on-rockingchair approved these changes

@dodys dodys dodys approved these changes

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels
bugfix Fixes to reported bugs. Infrastructure Our content build system
Projects
None yet
Milestone
0.1.73
Development

Successfully merging this pull request may close these issues.

cnss from SSG_REF_URIS points to a broken link
4 participants
@Mab879 @marcusburghardt @teacup-on-rockingchair @dodys