Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve playbook script and documention #11747

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Mar 22, 2024

Description:

  • Clean up utils/ansible_playbook_to_role.py
  • Add docs for utils/ansible_playbook_to_role.py

Rationale:

Follow up to #11495

Review Hints:

Follow the steps in the new docs.

@Mab879 Mab879 added Infrastructure Our content build system Documentation Update in project documentation. labels Mar 22, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Mar 22, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Mar 22, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11747
This image was built from commit: e8174ec

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11747

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11747 make deploy-local

@Mab879 Mab879 changed the title Improve playbook script Improve playbook script and documention Mar 29, 2024
@jan-cerny jan-cerny self-assigned this Apr 2, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the instructions in the doc and the script works fine. I also run the new tests locally and they passed.

if(SSG_PRODUCT_RHEL9)
file(MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/roles")
add_test(
NAME "utils-ansible-playbook-to-role-rhel9"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any GitHub CI job that runs this test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the requirements to make the tests run.

So the tests in utils/ansible_playbook_to_role.py run.
@Mab879 Mab879 requested a review from jan-cerny April 5, 2024 15:57
Copy link

codeclimate bot commented Apr 5, 2024

Code Climate has analyzed commit e8174ec and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

@jan-cerny
Copy link
Collaborator

/packit retest-failed

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen both tests running in the Build Test on Fedora Latest job.

@jan-cerny jan-cerny merged commit cdda807 into ComplianceAsCode:master Apr 9, 2024
45 checks passed
@Mab879 Mab879 deleted the improve_playbook_script branch April 9, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update in project documentation. Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants