Fix OCP node OVN check

[yuumasato]

Description:

• The OVAL check for OCP node platform check was outdated and only worked correctly on 4.12 and 4.13.
• The checked path has different contents on 4.14+
• Let's check OVN config on a path that is common for 4.12+.
  • /var/run/multus/cni/net.d/10-ovn-kubernetes.conf
• Delete e2e files for 4.12 and 4.13 that are aligned with the default e2e.yml file.

Rationale:

• The way multus-shim configures OVN on 4.12 and 4.13 is different from 4.14 on.

Review hints:

Manually tested on 4.12 and 4.14:

oc get ccr | grep ovn 
upstream-ocp4-cis-node-master-file-groupowner-ovn-cni-server-sock                      PASS     medium
upstream-ocp4-cis-node-master-file-groupowner-ovn-db-files                             PASS     medium
upstream-ocp4-cis-node-master-file-owner-ovn-cni-server-sock                           PASS     medium
upstream-ocp4-cis-node-master-file-owner-ovn-db-files                                  PASS     medium
upstream-ocp4-cis-node-master-file-permissions-ovn-cni-server-sock                     PASS     medium
upstream-ocp4-cis-node-master-file-permissions-ovn-db-files                            PASS     medium
upstream-ocp4-cis-node-worker-file-groupowner-ovn-cni-server-sock                      PASS     medium
upstream-ocp4-cis-node-worker-file-groupowner-ovn-db-files                             PASS     medium
upstream-ocp4-cis-node-worker-file-owner-ovn-cni-server-sock                           PASS     medium
upstream-ocp4-cis-node-worker-file-owner-ovn-db-files                                  PASS     medium
upstream-ocp4-cis-node-worker-file-permissions-ovn-cni-server-sock                     PASS     medium
upstream-ocp4-cis-node-worker-file-permissions-ovn-db-files                            PASS     medium

Raw results before patch:

<definition definition_id="oval:ssg-installed_app_is_ocp4_node_on_openshift-ovn:def:1" result="false" version="1">
  <criteria operator="AND" result="false">
    <criterion test_ref="oval:ssg-test_ocp4_on_openshift-ovn:tst:1" version="1" result="false"/>
    <criterion test_ref="oval:ssg-test_file_for_ocp4_node_network:tst:1" version="1" result="true"/>
  </criteria>
</definition>

Raw resutlts after patch:

<definition definition_id="oval:ssg-installed_app_is_ocp4_node_on_openshift-ovn:def:1" result="true" version="1">
  <criteria operator="AND" result="true">
    <criterion test_ref="oval:ssg-test_ocp4_on_openshift-ovn:tst:1" version="1" result="true"/>
    <criterion test_ref="oval:ssg-test_file_for_ocp4_node_network:tst:1" version="1" result="true"/>
  </criteria>
</definition>

[yuumasato]

/test help

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

[yuumasato]

/test 4.13-e2e-aws-ocp4-cis
/test 4.15-e2e-aws-ocp4-cis
/test 4.16-e2e-aws-ocp4-cis
/test e2e-aws-ocp4-cis

[yuumasato]

/test 4.13-e2e-aws-ocp4-cis-node
/test 4.15-e2e-aws-ocp4-cis-node
/test 4.16-e2e-aws-ocp4-cis-node
/test e2e-aws-ocp4-cis-node

[github-actions]

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11861
This image was built from commit: 7925bd0

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11861

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11861 make deploy-local

[codeclimate]

Code Climate has analyzed commit 7925bd0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.2% (0.0% change).

View more on Code Climate.

[yuumasato]

/test 4.16-e2e-aws-ocp4-cis

[rhmdnd]

/lgtm