Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RHEL 10 to SRG Mapping Table Action #11881

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Add RHEL 10 to SRG Mapping Table Action #11881

merged 2 commits into from
Apr 26, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Apr 24, 2024

Description:

Add RHEL 10 to SRG Mapping Table Action

Rationale:

Start build the RHEL 10 STIG.

@Mab879 Mab879 added the Documentation Update in project documentation. label Apr 24, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Apr 24, 2024
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11881
This image was built from commit: 606be7a

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11881

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11881 make deploy-local

@Mab879
Copy link
Member Author

Mab879 commented Apr 25, 2024

/packit retest-failed

@Mab879 Mab879 force-pushed the add_rhel10_to_srg_mapping_tables branch from eda8b71 to b66f810 Compare April 25, 2024 19:49
@Mab879 Mab879 force-pushed the add_rhel10_to_srg_mapping_tables branch from b66f810 to 83d219e Compare April 26, 2024 01:34
marcusburghardt
marcusburghardt requested changes Apr 26, 2024
View reviewed changes
.github/workflows/srg-mapping-table.yaml Outdated Show resolved Hide resolved
.github/workflows/srg-mapping-table.yaml Outdated Show resolved Hide resolved
@marcusburghardt marcusburghardt self-assigned this Apr 26, 2024
@Mab879 @marcusburghardt
Apply suggestions from code review
606be7a 
Co-authored-by: Marcus Burghardt <2074099+marcusburghardt@users.noreply.github.com>
marcusburghardt
marcusburghardt approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 26, 2024

Code Climate has analyzed commit 606be7a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.1% change).

View more on Code Climate.

@Mab879
Copy link
Member Author

Mab879 commented Apr 26, 2024

/test 4.15-images

@Mab879
Copy link
Member Author

Mab879 commented Apr 26, 2024

/retest-required

@marcusburghardt marcusburghardt merged commit 1753abf into ComplianceAsCode:master Apr 26, 2024
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels
Documentation Update in project documentation.
Projects
None yet
Milestone
0.1.73
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mab879 @marcusburghardt