Add zeit 2 support #1417
Merged
Add zeit 2 support #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaraVieira
commented
Jan 1, 2019
| 'now-start': `cd ${this.distDir} && serve -s ./`, | ||
| ...parsedFile.scripts, |
There was a problem hiding this comment.
This was moved because I may want to override your now-start
CompuIves
reviewed
Jan 2, 2019
| @@ -167,10 +121,11 @@ export async function aliasDeployment({ http, path, props, state }) { | |||
| export async function postToZeit({ http, path, props, state }) { | |||
| const { apiData } = props; | |||
| const token = state.get('user.integrations.zeit.token'); | |||
| const deploymentVersion = apiData.version === 2 ? 'v6' : 'v3'; | |||
There was a problem hiding this comment.
That's what my momma says
|
Kind of amazing that adding Zeit 2 actually removed more code then it added 😂 |
SaraVieira
commented
Jan 2, 2019
| @@ -101,13 +46,12 @@ export async function createApiData({ props, state }) { | |||
|
|
|||
| const nowDefaults = { | |||
| name: `csb-${sandbox.id}`, | |||
| type: 'NPM', | |||
There was a problem hiding this comment.
This was removed because it's actually the default now 1 uses and it was ruining version 2
|
|
||
| try { | ||
| const deployment = await http.request({ | ||
| url: 'https://api.zeit.co/v3/now/deployments', | ||
| url: `https://api.zeit.co/${deploymentVersion}/now/deployments?forceNew=1`, |
There was a problem hiding this comment.
In now 2 force new is passed like this and version 1 ignores it so yay
leo
approved these changes
Jan 2, 2019
timothyis
approved these changes
Jan 2, 2019
|
+1 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds support for zeit now version 2
What is the current behavior?
Currently we have a counter and it had like 500 people so I guess it's time
What is the new behavior?
If the now.json has
version:2specified the new now platform will be usedHere is an example:
https://codesandbox-v2-test.now.sh/graphql
Also all the other endpoints remained the same so it was easier then I thought o.o
cc @timothyis @rauchg