Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git submodules for picongpu and possible other required projects #11

Open
n01r opened this issue Feb 16, 2017 · 6 comments
Open

Add git submodules for picongpu and possible other required projects #11

n01r opened this issue Feb 16, 2017 · 6 comments

Comments

@n01r
Copy link
Member

n01r commented Feb 16, 2017

When I tried to do the Quickstart from README.md the configureExample.sh failed because it couldn't find picongpu/thirdParty/mallocMC.

To fix this and make ParaTAXIS work even though PMacc and mallocMC steadily evolve a git-submodule should be added. For now in CMakeLists.txt the path $HOME/picongpu is set as $PICONGPU_ROOT. That environment variable should point towards the relative path of the git-submodule picongpu.

@n01r n01r added this to the Future milestone Feb 16, 2017
@n01r n01r self-assigned this Feb 16, 2017
@n01r
Copy link
Member Author

n01r commented Feb 20, 2017

ParaTAXIS also seems to assume that its path is ~/parataxis.

@ax3l
Copy link
Member

ax3l commented Feb 20, 2017

Looks like no submodules involved. Try running ccmake . in your build dir after configuring.

I found in CMakeLists.txt that you can e.g. set the PIConGPU root to via cmake -DPICONGPU_ROOT=somePath ...

@n01r
Copy link
Member Author

n01r commented Feb 21, 2017

Yeah, sure, I contacted @Flamefire and he said that he forgot to add picongpu as a git-submodule.
He worked with the most recent dev until he left.

@n01r
Copy link
Member Author

n01r commented Feb 21, 2017

Update The default cmakeFlagsNr is set to -1 in configureExample.sh. But the compilation process requires the flag -DPARAM_PRECISION to be set. That would happen if the default were flags[0]. But as we've seen it is -1 and nothing is set.

Thanks @psychocoderHPC for finding this.

@Flamefire
Copy link
Contributor

Flamefire commented Jun 24, 2017

Actually it was never planned to add submodules as this should at some point be included in PIConGPU. So I used the often used pattern by using a variable _ROOT in the CMakeLists
Even more: This is only a helper. If there is a configured installation of MallocMC then it would be found w/o the picongpu path (

find_package(mallocMC 2.1.0 QUIET)
)
However there was no way to find PMacc through modules so there it is required unless it can be found otherwise (
find_path(PMACC_ROOT_DIR
)

So yes you can either install picongpu to the default location (which I set to be in the home) or point PICONGPU_ROOT to it.

About the flags: I think there was a change so that those defines have to be set instead of defaulting to something. So the default cmakeFlagsNr should be 0 I guess.

@Flamefire Flamefire mentioned this issue Jun 24, 2017
@ax3l
Copy link
Member

ax3l commented Jul 3, 2017

Cool, can you add such information to INSTALL.md or somewhere prominent in the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants