fix: don't render terminal linebreaks #1777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our markdown syntax does not support teminal line-breaks, either in blocks like a paragraph or just in text. We had correctly been suppressing rendering the slash-escaped line break when it appeared in a paragraph, but not in text
bachbui
force-pushed
the
terminal-linebreaks
branch
from
5fdf67c
to
b352160
Compare
bachbui
commented
Jun 27, 2024
| expect(CommonmarkRenderer.render(document)).toBe("test\\\ntest"); | ||
| }); | ||
|
|
||
| test.skip("in text terminating a mark", () => { |
There was a problem hiding this comment.
This test fails, but is at least consistent with the existing behavior we have with terminal linebreaks inside of a mark at the end of a block.
|
duped by #1776 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our markdown syntax does not support teminal line-breaks, either in blocks like a paragraph or just in text.
We had correctly been suppressing rendering the slash-escaped line break when it appeared in a paragraph, but not in text