Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dynamic url to HTTP processor + fix RawData bug #1498

Merged
merged 8 commits into from
Apr 18, 2024
Merged

add dynamic url to HTTP processor + fix RawData bug #1498

merged 8 commits into from
Apr 18, 2024

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Apr 17, 2024 •
edited

Description

Fixes #1495
Fixes #1497

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner April 17, 2024 18:46
@hariso
Copy link
Contributor

hariso commented Apr 18, 2024

@maha-hajja LGTM! Maybe we could also document which types are expected in StructuredData values? Or maybe even have methods on StructuredData that will check a value's type before storing it?

lovromazgon
lovromazgon approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a few suggestions for improvements 😉

pkg/plugin/processor/builtin/impl/webhook/http_examples_test.go Outdated Show resolved Hide resolved
pkg/plugin/processor/builtin/impl/webhook/http.go Outdated Show resolved Hide resolved
pkg/plugin/processor/builtin/impl/webhook/http_test.go Outdated Show resolved Hide resolved
raulb
raulb approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maha-hajja maha-hajja merged commit 4de440b into main Apr 18, 2024
3 checks passed
@maha-hajja maha-hajja deleted the maha/http-proc-dynamic-url branch April 18, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

@hariso hariso hariso approved these changes

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP Processor: change RawData into []byte HTTP Processor: dynamic request.url
4 participants
@maha-hajja @hariso @raulb @lovromazgon