fix(router): get middlewares route bug fixed #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkopanidis
approved these changes
May 13, 2022
kon14
requested changes
May 13, 2022
| return { result: response }; // unnested from result in Rest.addConduitRoute, grpc routes avoid this using wrapRouterGrpcFunction | ||
| // @ts-ignore | ||
| let actualResponse = Array.from(new Set(response)); | ||
| return { result: actualResponse }; // unnested from result in Rest.addConduitRoute, grpc routes avoid this using wrapRouterGrpcFunction |
There was a problem hiding this comment.
No need for a variable, return this directly.
| const module = router.getGrpcRoutes(); | ||
| Object.keys(module).forEach((url: string) => { | ||
| module[url].forEach((item: any) => { | ||
| if (item.returns == null && item.grpcFunction !== "") { | ||
| if (item.returns == null && !isNil(item.grpcFunction) && item.grpcFunction !== '') { |
There was a problem hiding this comment.
Do we really need the !isNil() here? Null / Undefined don't match ''.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #152
What kind of change does this PR introduce?
Does this PR introduce a breaking change?