Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): array type not extracted properly #182

Merged
merged 5 commits into from
Jun 2, 2022
Merged

Conversation

Michael-Vol
Copy link
Contributor

What kind of change does this PR introduce?
This PR fixes an issue where the extracted array type in Mongoose is "Array".

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch

@Michael-Vol Michael-Vol requested review from kkopanidis and kon14 and removed request for kkopanidis June 1, 2022 11:03
@kon14 kon14 requested a review from sdimitris June 1, 2022 11:07
Copy link
Contributor

@kkopanidis kkopanidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

talked in call about the issue. Basically types are not properly kept

@Michael-Vol Michael-Vol requested a review from kon14 June 2, 2022 14:10
@kkopanidis kkopanidis merged commit 7cb2546 into main Jun 2, 2022
@kkopanidis kkopanidis deleted the db-introspect branch June 2, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants