Independent Config Route Creation for Packages & Modules #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-Vol
force-pushed
the
config-validation
branch
from
0dbd60a
to
4353f27
Compare
Michael-Vol
force-pushed
the
config-validation
branch
from
4353f27
to
5463ca7
Compare
kon14
approved these changes
Jul 26, 2022
packages/core/src/config-manager/admin/routes/GetConfig.route.ts
Outdated
Show resolved
Hide resolved
packages/core/src/config-manager/admin/routes/PatchConfig.route.ts
Outdated
Show resolved
Hide resolved
kon14
requested changes
Jul 26, 2022
kon14
approved these changes
Jul 26, 2022
kkopanidis
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for generating config routes independently for each package and module. It also introduces strict convict configuration validation in order to prevent users from adding irrelevant fields into the config.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)