Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): gRPC schema registration removing schema extensions from adapter models #293

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Aug 26, 2022

This addresses a bug where incoming gRPC schema registrations would remove a schema's extensions from its adapter model, effectively dropping its extensions until the Database gets restarted and the adapters repopulated with the contents of DeclaredSchema.

To reproduce:

  • Start Core
  • Debug Database and set an extension in createSchemaFromAdapter() (or similar)
  • Notice how any extended schemas coming from DeclaredSchemas list their extensions as expected
  • Bring up a module owning an extended schema
  • Notice how that same schema is reregistered without any extensions

I'm using a hacky type any cast for the schema object as the schema types are already messed up to the point where it wouldn't be worth attempting to retype this on the spot.
We'll have to clean these up properly.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

@kkopanidis kkopanidis merged commit 47bf1c9 into main Aug 26, 2022
@kkopanidis kkopanidis deleted the fix-model-extensions branch August 26, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants