-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core,admin,testing-tools): core and admin tests #317
Conversation
…o core_rpc_service_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eslint is not parsing this somehow. Run manually.
…o core_rpc_service_tests
libraries/testing-tools/src/interfaces/IRRunDependenciesInterface.ts
Outdated
Show resolved
Hide resolved
libraries/testing-tools/src/interfaces/IRRunDependenciesInterface.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests shouldn't be automatically built together with their corresponding packages as that will increase build times.
We just need tests to be built and run on PRs.
@ChrisPdgn generally looks good I think. 2 points we need to fix: Coverage, and wait for the full release of 0.15 |
Introducing unit testing in core rpc services and admin using jest.
Fix: add 'config' prefix to '/modules' excluded route on Auth.middleware
Does this PR introduce a breaking change?
The PR fulfills these requirements:
main
branchfix #xxx
, where "xxx" is the issue number)