Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core,admin,testing-tools): core and admin tests #317

Merged
merged 53 commits into from
Oct 24, 2022

Conversation

sdimitris
Copy link
Contributor

@sdimitris sdimitris commented Sep 8, 2022

Introducing unit testing in core rpc services and admin using jest.

Fix: add 'config' prefix to '/modules' excluded route on Auth.middleware

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

@sdimitris sdimitris marked this pull request as draft September 8, 2022 07:57
@sdimitris sdimitris marked this pull request as ready for review September 12, 2022 09:01
Copy link
Contributor

@kon14 kon14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint is not parsing this somehow. Run manually.

packages/core/src/tests/grpc/config.test.js Outdated Show resolved Hide resolved
packages/core/src/tests/grpc/config.test.js Outdated Show resolved Hide resolved
packages/core/src/tests/mocks/module/TestModule.ts Outdated Show resolved Hide resolved
@kon14 kon14 changed the title Core rpc service tests feat: initial Core gRPC service tests Sep 12, 2022
@ChrisPdgn ChrisPdgn marked this pull request as ready for review October 6, 2022 15:21
libraries/testing-tools/src/index.ts Outdated Show resolved Hide resolved
packages/core/jest.config.js Outdated Show resolved Hide resolved
@kkopanidis kkopanidis marked this pull request as draft October 7, 2022 08:35
@ChrisPdgn ChrisPdgn changed the title feat: initial Core gRPC service tests feat(core,admin,testing-tools): core and admin tests Oct 14, 2022
@ChrisPdgn ChrisPdgn marked this pull request as ready for review October 17, 2022 12:20
kon14
kon14 previously requested changes Oct 18, 2022
Copy link
Contributor

@kon14 kon14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests shouldn't be automatically built together with their corresponding packages as that will increase build times.
We just need tests to be built and run on PRs.

@kkopanidis
Copy link
Contributor

@ChrisPdgn generally looks good I think. 2 points we need to fix: Coverage, and wait for the full release of 0.15

@kkopanidis kkopanidis dismissed kon14’s stale review October 24, 2022 13:13

will be addressed post-merge

@kkopanidis kkopanidis merged commit b2a9d9d into main Oct 24, 2022
@kkopanidis kkopanidis deleted the core_rpc_service_tests branch October 24, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants