Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hermes): named route response types handled as string responses #331

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Sep 19, 2022

Fixes a bug where named route response types where handled as string responses.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

@kkopanidis kkopanidis merged commit 6d86c10 into main Sep 19, 2022
@kkopanidis kkopanidis deleted the fix-stringified-responses branch September 19, 2022 12:21
kon14 added a commit that referenced this pull request Sep 22, 2022
Corresponding GraphQL fix in #331 (eyJhbG) only addressed Queries.
kkopanidis pushed a commit that referenced this pull request Sep 22, 2022
Corresponding GraphQL fix in #331 (eyJhbG) only addressed Queries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants