Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): get admin by id, unselect admin password field #341

Merged
merged 4 commits into from
Sep 22, 2022

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Sep 22, 2022

This PR introduces a new administrative route for retrieving unique admin users by id (/admins/:id).
Passing in me as the admin id returns the authenticated user performing the request.

I also removed password from Admin schema's default field selection, explicitly selecting it where required and performed some minor cleanups across the place.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

@kkopanidis kkopanidis merged commit 9d02f02 into main Sep 22, 2022
@kkopanidis kkopanidis deleted the admin-updates branch September 22, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants